Skip to content

Conversation

@maxfriedmann
Copy link
Contributor

@maxfriedmann maxfriedmann commented Apr 4, 2025

In my project I need to extend the default collection. There are some util methods that return a modified query, would be nice to use the types from SignalDB directly.

In addition I figured out that the types DotNotation & GetType have a 99.9% overlap with types on my side. I'd also like to use the ones from SignalDB here.

@maxfriedmann maxfriedmann marked this pull request as ready for review April 4, 2025 07:15
@maxfriedmann maxfriedmann marked this pull request as draft April 4, 2025 07:21
@maxnowack
Copy link
Owner

Thanks for the PR! There was an issue running the CI. I just fixed it. Please rebase your PR 🙂

@maxfriedmann
Copy link
Contributor Author

I had a type issue on my side and thought I would need Query/FlatQuery but I could eventually resolve it. I can now rely just on Selector.

Would still be nice to have DotNotation and GetType :)

@maxfriedmann maxfriedmann marked this pull request as ready for review April 4, 2025 07:45
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (82fde4e) to head (2c9db11).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1591   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         1789      1789           
  Branches       417       417           
=========================================
  Hits          1789      1789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxnowack
Copy link
Owner

maxnowack commented Apr 4, 2025

Github says that there are merge conflicts somehow. Could you please rebase again?

this was an issue on my side

@maxnowack maxnowack merged commit b88d687 into maxnowack:main Apr 4, 2025
14 checks passed
@maxnowack
Copy link
Owner

published in @signaldb/[email protected] 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants