Support for MSC3814 - Dehydrated devices v2 #2349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
- Coverage 77.78% 77.69% -0.09%
==========================================
Files 175 176 +1
Lines 18619 18655 +36
==========================================
+ Hits 14482 14494 +12
- Misses 4137 4161 +24
☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/device-dehydration-pr
branch
2 times, most recently
from
c1107be to
7131fcf
Compare
This was referenced Aug 7, 2023
jplatte
requested changes
Aug 8, 2023
poljar
force-pushed
the
poljar/device-dehydration-pr
branch
from
72b2a1d to
31c8285
Compare
Contributor
Author
|
Force pushed after a rebase onto main to get the CI going. |
jplatte
approved these changes
Aug 9, 2023
This splits the method out so the bigger chunks doesn't persist the changes in the store. This will be useful if we need to hijack the changes and persist them in a different store.
Co-authored-by: Jonas Platte <[email protected]>
poljar
force-pushed
the
poljar/device-dehydration-pr
branch
from
3941c10 to
38cdc6a
Compare
Hywan
reviewed
Aug 10, 2023
Comment on lines
+40
to
+42
| // TODO: Once a device has been rehydrated it might need to download and decrypt | ||
| // a lot of to-device events. This process might take some time and we should | ||
| // support resuming it. |
Member
There was a problem hiding this comment.
@poljar Do we have an issue to not forget about this?
Contributor
Author
There was a problem hiding this comment.
We have, albeit a task/issue on the crypto board and the meta repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for MSC3814. This is best reviewed commit by
commit.
It's best to get an overview of the MSC first, the docs in the
dehydrated_devicessubmodule attempt to explain dehydrated devices as well.This closes: #401.