Add a `PropertyWidget` for plotting layer properties

[dstansby]

[jo-mueller]

Hi @dstansby ,

thanks for creating this issue. Just to clarify - what should this widget do? Would it be an interface between layer.properties and the canvas implementation in this repository? I think the Table Widget in napari-skimage-regionprops could already go a long way here.

Selecting two columns in a tabular view on measured properties of a layer could then trigger the plotting functions in this repository :)

[kevinyamauchi]

Hello @dstansby ! Thanks for the super nice library. I've already learned some things about matplotlib just looking through your code :).

If you're open to the PR, I am about to board a long flight and could make an attempt at a scatter plot and histogram widget that work off of the napari features/properties table.

Initially, I would use the current behavior which selects the data based on the currently selected layer in the napari layer list. In the future, would you be open to offering widgets that allow the selection of the data source to be separate from the selection of the layer from the layer list. I think this is helpful, as some plugins may want to maintain the plotting from one layer while interacting with others.

cc @jo-mueller

[dstansby]

Hello @dstansby ! Thanks for the super nice library. I've already learned some things about matplotlib just looking through your code :).

Thanks!

If you're open to the PR, I am about to board a long flight and could make an attempt at a scatter plot and histogram widget that work off of the napari features/properties table.

Yes, PRs are very encouraged! I don't know much about feature/property tables, so it would be great for someone with more knowledge to have a go at this.

Initially, I would use the current behavior which selects the data based on the currently selected layer in the napari layer list. In the future, would you be open to offering widgets that allow the selection of the data source to be separate from the selection of the layer from the layer list. I think this is helpful, as some plugins may want to maintain the plotting from one layer while interacting with others.

If there's a compelling use case, I'd definiltey be open to that. I did a bit of a refactor yesterday in https://github.com/dstansby/napari-matplotlib/pull/33 to move the layer selection callbacks on to the base widget, but it should be possible to override that behaviour by overriding setup_callbacks() to do nothing.

[jo-mueller]

Hey @kevinyamauchi ,

I have also started working on this here - feel free to check whether there is something you find useful!

[kevinyamauchi]

Thanks, @jo-mueller ! I see that you started adding a table implementation. I didn't add a table in my PR and I think that would be a super useful feature to have as well!

[jo-mueller]

The table implement is @haesleinhuepf 's implementation from napari-skimage-regionprops - maaaaybe we could eventually move it here - I think it makes more sense to have napari-matplotlib as a dependency of napari-skimage-regionprops than the other way around :)

[kevinyamauchi]

Works for me! Thanks for the quick reply @jo-mueller

[dstansby]

Fixed by #39