Skip to content

Removing a TODO comment in plotting.py #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

anbarief
Copy link
Contributor

@anbarief anbarief commented Mar 2, 2022

Remove the comment

    # ----------------------------------------------------------------------
    # TODO:  Add some warnings, or raise an exception, if external_axes_mode
    #        and user is trying to figscale, figratio, or figsize.
    # ----------------------------------------------------------------------

Since this TODO has been done in line 408.

anbarief added 2 commits March 2, 2022 08:41
Remove the comment  
`` # ----------------------------------------------------------------------
    # TODO:  Add some warnings, or raise an exception, if external_axes_mode
    #        and user is trying to figscale, figratio, or figsize.
    # ----------------------------------------------------------------------``

Since this TODO has been done in line 420.
@DanielGoldfarb
Copy link
Collaborator

@anbarief
Arief- Thanks for contributing. --Daniel

@DanielGoldfarb DanielGoldfarb merged commit 3f36111 into matplotlib:master Mar 2, 2022
@DanielGoldfarb DanielGoldfarb added the released code merged into repo AND released to Pypi label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released code merged into repo AND released to Pypi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants