Skip to content

Conversation

@manabu-nakamura
Copy link
Contributor

@hunterstich hunterstich self-assigned this Oct 11, 2023
@hunterstich hunterstich added Reviewing Internally An internal change has been created and sent for review. Feature: Predictive Back Widget: NavigationView and removed Feature: Predictive Back labels Oct 11, 2023
@manabu-nakamura
Copy link
Contributor Author

Is the code for the predictive back in drawerlayout:1.2.0 unneccesary?
The catalog app doesn't use drawerlayout:1.2.0 but uses drawerlayout:1.1.1.
https://developer.android.com/jetpack/androidx/releases/drawerlayout#1.2.0

@dsn5ft
Copy link
Contributor

dsn5ft commented Oct 12, 2023

Correct, NavigationView detects when it is inside a DrawerLayout and then it enables back handling with the predictive animation.

I believe while DrawerLayout does add back callbacks, it does not have any predictive animation.

@drchen drchen closed this in 74ac87c Oct 12, 2023
@manabu-nakamura manabu-nakamura deleted the navigationdrawer2 branch October 12, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewing Internally An internal change has been created and sent for review. Widget: NavigationView

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants