Skip to content

Conversation

@pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Apr 20, 2023

This PR returns the missing diff between the commit in the master branch and the proposed PR:

  • No need to invalidate the badge when clearing an already clear value (as it was in 1.8.0 and before).
  • Fix table formatting in BadgeDrawable.md.
  • Some small fixes.

@imhappi
Copy link
Contributor

imhappi commented Apr 21, 2023

Thanks for the PR as always @pubiqq !

Please note that the suffix name was changed from mtrl_exceed_max_badge_text_suffix to m3_exceed_max_badge_text_suffix intentionally, as we use the mtrl prefix for values that reflect the m2 style, and m3 accordingly for m3.

Will submit the change to stop invalidating the badge when it is already clear, and the table formatting in BadgeDrawable.md

@pubiqq
Copy link
Contributor Author

pubiqq commented Apr 24, 2023

Please note that the suffix name was changed from mtrl_exceed_max_badge_text_suffix to m3_exceed_max_badge_text_suffix intentionally, as we use the mtrl prefix for values that reflect the m2 style, and m3 accordingly for m3.

*_exceed_max_badge_text_suffix is used in both m2 and m3 styles, so, I think, it's not correct to use the m3 prefix for it.

@imhappi
Copy link
Contributor

imhappi commented Apr 24, 2023

While used for both m2 and m3 styles, this value was introduced in m3 and reflects our current m3 style which is why it uses the m3 prefix.

@pubiqq
Copy link
Contributor Author

pubiqq commented Apr 24, 2023

But it doesn't reflect the m3 style specifically, it's not even used in m3 by default.
Anyway, it's not that crucial to me, so do as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants