[MaterialCardView] Added option to set the checkedIcon gravity #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKasaei00
reviewed
Feb 26, 2021
Comment on lines
+132
to
+137
| @IntDef({ | ||
| CHECKED_ICON_GRAVITY_TOP_START, | ||
| CHECKED_ICON_GRAVITY_BOTTOM_START, | ||
| CHECKED_ICON_GRAVITY_TOP_END, | ||
| CHECKED_ICON_GRAVITY_BOTTOM_END | ||
| }) |
There was a problem hiding this comment.
I think it is better to have both the vertical and horizontal gravity not the mixture of both and also center alignment would be helpful
drchen
reviewed
Jul 15, 2021
lib/java/com/google/android/material/card/MaterialCardViewHelper.java
Outdated
Show resolved
Hide resolved
lib/java/com/google/android/material/card/MaterialCardViewHelper.java
Outdated
Show resolved
Hide resolved
lib/java/com/google/android/material/card/MaterialCardViewHelper.java
Outdated
Show resolved
Hide resolved
lib/java/com/google/android/material/card/MaterialCardViewHelper.java
Outdated
Show resolved
Hide resolved
drchen
approved these changes
Nov 3, 2021
drchen
added
the
Reviewing Internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the checkedIcon in the
MaterialCardViewis positioned on the top|end corner.With this PR is possible to configure the
checkedIconGravity.It preserves the current default behavior.