-
Notifications
You must be signed in to change notification settings - Fork 69
gdal-2.1.3: Add a default value for CXX variable. #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice catch. This is defined for some platforms, but not all, I realize. This was my mistake. I'm thinking it would be better to properly set a default in Here are all the packages that would need fixed, per package: |
|
There are actually many more scripts which assume CXX to be set without exporting it (e.g. mapnik, gdal). It's indeed best to make sure reasonable defaults are set in mason.sh, as they are for at least osx and android. |
7ab1b0a to
fc6d5dc
Compare
|
I changed this PR to set the CC and CXX vars for Linux in mason.sh. |
|
How about something like: + export CXX="${CXX:-c++}"
+ export CC="${CC:-cc}"That will allow them to be customized (which is important since we build with clang++ on travis by setting CXX). And it will use the more generic symlinks to the compilers (which I presume will work on more linux systems and bsd systems). |
fc6d5dc to
e72d3b1
Compare
|
Good idea, I've updated the PR. |
|
On second thought, setting CC=cc etc. obviously breaks boost build scripts as they are now. Using readlink and some heuristics in boost scripts probably can fix this. |
e72d3b1 to
c32326c
Compare
|
I added a commit to this PR, which determines the BOOST_TOOLSET* vars in boost build scripts from the CC variable. It supports only gcc and clang though. |
|
Going to close this since #692 landed. Please re-open new issues for anything no yet fixed. |
At least on my system the 'CXX' environment variable is not set by default. This makes the gdal-2.1.3 mason build fail. This PR adds a reasonable default value.