lgtnfght: removed NMI connection as it does not exist on schematics. #13819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a sanity check, have you checked continuity on a real board to ensure it isn’t an error in the schematic? It could have a pullup resistor as well as a connection if it’s being driven from an open collector output, for example. |
|
No NMI routine at 0x66 in the Z80 ROM. |
happppp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigon schematics show a pull-up resistor at the NMI pin. However, the driver connects that signal.
This PR removes the connection in the driver. The sound is not affected after the change.
I created a separate branch in my fork for this, so feel free to push other changes to it.