fix wireup.ioc.util.get_globals
#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @maldoinc that should be a quick one :) |
maldoinc
requested changes
Dec 10, 2025
maldoinc
reviewed
Dec 10, 2025
Owner
maldoinc
left a comment
maldoinc
left a comment
There was a problem hiding this comment.
Looks good, just some minor comments then it's ready to merge.
added 3 commits
December 10, 2025 21:14
Contributor
Author
|
@maldoinc both addressed! |
maldoinc
approved these changes
Dec 11, 2025
Owner
maldoinc
left a comment
maldoinc
left a comment
There was a problem hiding this comment.
Thank you @MuriloScarpaSitonio!
Contributor
Author
|
Thanks @maldoinc! Looking forward for the next release, let me know! |
Contributor
Author
|
Hey @maldoinc any chance we can get this released today or tomorrow? Sorry for insisting so much but I have a bunch of code for a new project in my company using |
Owner
|
I'll tag a release in ~8 hours. |
Contributor
Author
|
Thank you!!! |
Owner
|
v2.2.0 is now out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use
wireupwithdjango-ninjaand the django integration middleware is breaking due the fact thatdjango-ninjaviews arefunctools.partialfunctions.Please also check #91