feat: Add DRF integration #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maldoinc
reviewed
Nov 29, 2025
Owner
maldoinc
left a comment
maldoinc
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Looks great, just a few typos and minor comments:
We might want to check double injections: At the moment, using @inject on a regular django view will result in it being injected twice, one from the decorator and the other from the auto decoration the integration does to all its views. We can update one of them to skip injection if the other has already done it or think about a wireup setting such as "auto inject django views" which can be set to false if users want to use @inject on regualr django views instead.
Contributor
Author
|
@maldoinc I think I addressed your remark by raising an error in this scenario. Can you take another look? |
maldoinc
reviewed
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the directives of #78.