Skip to content

Conversation

Susucre
Copy link
Contributor

@Susucre Susucre commented Oct 12, 2023

A couple fix on counter distribution:

  • Feast of the Victorious Dead was incorrect on situations where there is no creatures to distribute counters onto (the life was not gained), and incorrectly allowed the player to not distribute although it is mandatory if there is at least one creature to distribute onto.
  • Awaken the Maelstrom was incorrectly allowing to not distribute although the player should if there is at least one creature to distribute onto.

@github-actions
Copy link

Feast of the Victorious Dead - (Gatherer) (Scryfall) (EDHREC)

{W}{B}
Enchantment
At the beginning of your end step, if one or more creatures died this turn, you gain that much life and distribute that many +1/+1 counters among creatures you control.

Invasion of Alara // Awaken the Maelstrom - (Gatherer) (Scryfall) (EDHREC)

{W}{U}{B}{R}{G}
Battle — Siege
When Invasion of Alara enters the battlefield, exile cards from the top of your library until you exile two nonland cards with mana value 4 or less. You may cast one of those two cards without paying its mana cost. Put one of them into your hand. Then put the other cards exiled this way on the bottom of your library in a random order.
🔄
Sorcery
Awaken the Maelstrom is all colors.
Target player draws two cards. You may put an artifact card from your hand onto the battlefield. Create a token that's a copy of a permanent you control. Distribute three +1/+1 counters among one, two, or three creatures you control. Destroy target permanent an opponent controls.

Copy link
Contributor

@xenohedron xenohedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other potentially bugged cards: https://scryfall.com/search?q=o%3Adistribute+o%3Acounters+-o%3Atarget

I think it could be good to automatically set min/max targets as part of the TargetAmount constructor to be correct in most common scenarios.

@Susucre
Copy link
Contributor Author

Susucre commented Oct 14, 2023

Blessing of Frost and Vastwood Hydra have the same min=0 issue.
Stumpsquall Hydra just does not put any counter in any situation.

@Susucre
Copy link
Contributor Author

Susucre commented Oct 14, 2023

Alright fixed them all (Stumpsquall Hydra was not using the apparently only correct way to target an mount with target.chooseTarget instead of player.chooseTarget).

Code could be refactored from there / modified to not have to set the min 1 when there is at least 1 creature to distribute onto, but for now I think I'll settle for the fix of the individual effects.

@Susucre Susucre changed the title Fix Feast of the Victorious Dead and Awaken the Maelstrom Fix Feast of the Victorious Dead and 4 others distributing counters without targetting Oct 14, 2023
@xenohedron xenohedron merged commit 0f98770 into magefree:master Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants