This repository was archived by the owner on Dec 7, 2020. It is now read-only.
Update OAuth2 dependency #518 #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jangaraj would you like to review? |
- package "crypto/rand" is being imported twice - Remove unused reference - Upgrade to golang/x/oauth2 Resolves louketo#518
Author
|
@ASzc we don't need to rush on this, but could you please give it a try? If you need more details about the work on this PR, I can add to the description. |
Contributor
|
@abstractj Yes, I can have a look at it after KEYCLOAK-14329 |
Contributor
|
Starting to have a look at this today |
ASzc
approved these changes
Jun 22, 2020
Contributor
ASzc
left a comment
ASzc
left a comment
There was a problem hiding this comment.
I can't see any issues with this. Although I'm not familiar with either library, I've had a look through the documentation and the new library seems to be used correctly relative to the old one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #518