Skip to content

Creating a Disruptor instance with an Executor is deprecated in favour of a ThreadFactory #567

@brenuart

Description

@brenuart

The AsyncDisruptorAppender creates Disruptor instances using the constructor that takes an Executor as argument.
This constructor has been deprecated in 2015 in favour of a ThreadFactory. The deprecation comments says:

Use a {@link ThreadFactory} instead of an {@link Executor} as a ThreadFactory is able to report errors when it is unable to construct a thread to run a producer.

The deprecation has been introduced by commit LMAX-Exchange/disruptor@4273056 and is in effect since version 3.3.4.

The AsyncDisruptorAppender already maintains a ThreadFactory. I don't see any problem in passing it to the Disruptor instead of the executor service.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions