Skip to content

Conversation

FabianKramm
Copy link
Member

resolves ENG-7912

With old restore method (before this patch) there is an issue where we do not bump the revision number or compact it which leads to watches getting stale as the revision number decreases.

Changes:

  • Biggest changes come from dependency "modernc.org/sqlite v1.29.10", which we already have in vcluster-pro so ultimately this shouldn't add much new code. The rest is from requiring "go.etcd.io/etcd/server/v3/storage/backend", which is needed for reading the raw etcd database
  • We get the latest revision before restoring from the current database and then bumping it when starting the backing store
  • We also compact the latest revision after restoring the database
  • New safeguard function that reverts changes being done should the restore fail

@FabianKramm FabianKramm requested review from hidalgopl, a team, zerbitx and lizardruss as code owners July 24, 2025 11:21
@FabianKramm FabianKramm force-pushed the main branch 2 times, most recently from fb6c78a to a4aae5d Compare July 24, 2025 11:41
Copy link
Contributor

@johannesfrey johannesfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FabianKramm FabianKramm merged commit bdc39fa into loft-sh:main Jul 24, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants