feat: RewriteHosts initContainer image may use override image #2992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squ94wk
force-pushed
the
ENG-6911_init-container-image
branch
2 times, most recently
from
3d34bcc to
42723c2
Compare
FabianKramm
requested changes
Jul 17, 2025
BREAKING CHANGE: Change config.sync.toHost.pods.rewriteHosts.initContainer.image from string to struct.
squ94wk
force-pushed
the
ENG-6911_init-container-image
branch
from
42723c2 to
1865378
Compare
squ94wk
force-pushed
the
ENG-6911_init-container-image
branch
from
1865378 to
623cff9
Compare
FabianKramm
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Change config.sync.toHost.pods.rewriteHosts.initContainer.image from string to struct.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)This changes the config for the "rewriteHosts" feature to be in line with other places.
The init container will now also use the
config.controlPlane.advanced.defaultRegistry.Please provide a short message that should be published in the vcluster release notes
Allow to use a custom registry for the rewriteHosts init container.
BREAKING CHANGE: replaced the config string
sync.toHost.pods.rewriteHosts.initContainer.imagewith object that takesregistry,repository,tag.What else do we need to know?