Skip to content

fix(utils/**.py): fix comparison to None #94022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix(utils/**.py): fix comparison to None #94022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/bazel/configure.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def _extract_cmake_settings(repository_ctx, llvm_cmake):
# Skip if `CMAKE_CXX_STANDARD` is set with
# `LLVM_REQUIRED_CXX_STANDARD`.
# Then `v` will not be desired form, like "${...} CACHE"
if c[k] != None:
if c[k] is not None:
continue

# Pick up 1st word as the value.
Expand Down Expand Up @@ -160,7 +160,7 @@ def _llvm_configure_impl(repository_ctx):
repository_ctx,
"cmake/Modules/LLVMVersion.cmake",
)
version = {k: v for k, v in version.items() if v != None}
version = {k: v for k, v in version.items() if v is not None}
vars.update(version)

_write_dict_to_file(
Expand Down