Skip to content

[libc++] Fix endianness for algorithm mismatch #93082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 11, 2024
Merged

[libc++] Fix endianness for algorithm mismatch #93082

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e366cb1
Fix endianess for algorithm mismatch
zibi2 May 22, 2024
05395e0
Update based on the latest changes
zibi2 May 22, 2024
b4ce872
Add more __reverse_vector overloads
zibi2 May 22, 2024
40cab24
Try to fix windows CI
zibi2 May 24, 2024
42f64c8
Based on the suggestion, apply the variadic template technique to red…
zibi2 Jun 3, 2024
8cddb83
fix formatting
zibi2 Jun 3, 2024
9bf257d
attempt to fix CI
zibi2 Jun 3, 2024
5eba555
Make __find_first_set endianness aware
zibi2 Jun 10, 2024
cf070c4
Remove conditinal statement for #include directive
zibi2 Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion libcxx/include/__algorithm/simd_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@

#include <__algorithm/min.h>
#include <__bit/bit_cast.h>
#include <__bit/countr.h>
#if defined(_LIBCPP_BIG_ENDIAN)
# include <__bit/countl.h>
#else
# include <__bit/countr.h>
#endif
#include <__config>
#include <__type_traits/is_arithmetic.h>
#include <__type_traits/is_same.h>
Expand Down Expand Up @@ -126,8 +130,13 @@ _LIBCPP_NODISCARD _LIBCPP_HIDE_FROM_ABI size_t __find_first_set(__simd_vector<_T

// This has MSan disabled du to https://github.com/llvm/llvm-project/issues/85876
auto __impl = [&]<class _MaskT>(_MaskT) _LIBCPP_NO_SANITIZE("memory") noexcept {
# if defined(_LIBCPP_BIG_ENDIAN)
return std::min<size_t>(
_Np, std::__countl_zero(__builtin_bit_cast(_MaskT, __builtin_convertvector(__vec, __mask_vec))));
# else
return std::min<size_t>(
_Np, std::__countr_zero(__builtin_bit_cast(_MaskT, __builtin_convertvector(__vec, __mask_vec))));
# endif
};

if constexpr (sizeof(__mask_vec) == sizeof(uint8_t)) {
Expand Down