Skip to content

[WIP] [lldb][Progress] Report progress when completing types from DWARF #91452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[WIP] [lldb][Progress] Report progress when completing types from DWARF #91452

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9d0e0d
[lldb][DWARFASTParserClang] Report progress when parsing types from D…
Michael137 May 8, 2024
5dc8369
fixup! rephrase progress message
Michael137 Jun 11, 2024
66c59d3
Merge branch 'main' into lldb/expr-progress-events
Michael137 Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "Plugins/ExpressionParser/Clang/ClangUtil.h"
#include "Plugins/Language/ObjC/ObjCLanguage.h"
#include "lldb/Core/Module.h"
#include "lldb/Core/Progress.h"
#include "lldb/Core/Value.h"
#include "lldb/Host/Host.h"
#include "lldb/Symbol/CompileUnit.h"
Expand Down Expand Up @@ -1758,6 +1759,11 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc,
}

if (attrs.is_forward_declaration) {
Progress progress(llvm::formatv(
"Parsing forward declaration {0}: {1}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should either be "Resolving forward declaration" or "Parsing type". Otherwise it sounds like we take a long time to load a forward declaration itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

dwarf->GetObjectFile()->GetFileSpec().GetFilename().GetString(),
attrs.name.GetString()));

// We have a forward declaration to a type and we need to try and
// find a full declaration. We look in the current type index just in
// case we have a forward declaration followed by an actual
Expand Down