Skip to content

[flang][OpenMP] Add TODOs for target [teams|parallel] private #143706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

[flang][OpenMP] Add TODOs for target [teams|parallel] private #143706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions flang/lib/Lower/OpenMP/OpenMP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4317,6 +4317,13 @@ static void genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
parser::ToUpperCaseLetters(llvm::omp::getOpenMPClauseName(clause.id));
TODO(clauseLocation, name + " clause is not implemented yet");
}

if (std::holds_alternative<clause::Private>(clause.u) &&
origDirective == llvm::omp::Directive::OMPD_target_teams)
TODO(clauseLocation, "TARGET TEAMS PRIVATE is not implemented yet");
if (std::holds_alternative<clause::Private>(clause.u) &&
origDirective == llvm::omp::Directive::OMPD_target_parallel)
TODO(clauseLocation, "TARGET PARALLEL PRIVATE is not implemented yet");
Comment on lines +4321 to +4326
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you do this inside of genTeamsClauses: that would be more in line with how other TODOs in this file are located.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My rationale for putting this here was that by the time we're inside genTeamsClauses we're no longer processing the compound "target teams", rather just the "teams" construct on its own. Do we just want to show the TODO whenever teams is used with private in any scenario?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh good point. I'm not sure about the state of teams private but lets not disable it just in case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, teams + private is just not implemented outright so it should be okay in that case. But parallel + private without target seems to be implemented and tested quite extensively.

}

llvm::omp::Directive directive =
Expand Down
13 changes: 13 additions & 0 deletions flang/test/Lower/OpenMP/Todo/target-parallel-private.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
! RUN: %not_todo_cmd bbc -emit-fir -fopenmp -fopenmp-version=50 -o - %s 2>&1 | FileCheck %s
! RUN: %not_todo_cmd %flang_fc1 -emit-fir -fopenmp -fopenmp-version=50 -o - %s 2>&1 | FileCheck %s

!===============================================================================
! `private` clause on `target parallel`
!===============================================================================

! CHECK: not yet implemented: TARGET PARALLEL PRIVATE is not implemented yet
subroutine target_teams_private()
integer, dimension(3) :: i
!$omp target parallel private(i)
!$omp end target parallel
end subroutine
13 changes: 13 additions & 0 deletions flang/test/Lower/OpenMP/Todo/target-teams-private.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
! RUN: %not_todo_cmd bbc -emit-fir -fopenmp -fopenmp-version=50 -o - %s 2>&1 | FileCheck %s
! RUN: %not_todo_cmd %flang_fc1 -emit-fir -fopenmp -fopenmp-version=50 -o - %s 2>&1 | FileCheck %s

!===============================================================================
! `private` clause on `target teams`
!===============================================================================

! CHECK: not yet implemented: TARGET TEAMS PRIVATE is not implemented yet
subroutine target_teams_private()
integer, dimension(3) :: i
!$omp target teams private(i)
!$omp end target teams
end subroutine
Loading