Skip to content

[RISCV] RVA23S64 should include H extension #115572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ppenzin
Copy link
Contributor

@ppenzin ppenzin commented Nov 9, 2024

RVA23 defines Hypervisor (H) extension to be required for RVA23S64:

https://drive.google.com/file/d/12QKRm92cLcEk8-5J9NI91m0fAQOxqNAq/view?usp=sharing

Copy link

github-actions bot commented Nov 9, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@ppenzin ppenzin marked this pull request as draft November 9, 2024 00:32
@llvmbot
Copy link
Member

llvmbot commented Nov 9, 2024

@llvm/pr-subscribers-backend-risc-v

Author: Petr Penzin (ppenzin)

Changes

RVA23 defines Hypervisor (H) extension to be required for RVA23S64:

https://drive.google.com/file/d/12QKRm92cLcEk8-5J9NI91m0fAQOxqNAq/view?usp=sharing


Full diff: https://github.com/llvm/llvm-project/pull/115572.diff

1 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVProfiles.td (+2-1)
diff --git a/llvm/lib/Target/RISCV/RISCVProfiles.td b/llvm/lib/Target/RISCV/RISCVProfiles.td
index cbf2a2eddf38ed..a2bedb4be83567 100644
--- a/llvm/lib/Target/RISCV/RISCVProfiles.td
+++ b/llvm/lib/Target/RISCV/RISCVProfiles.td
@@ -77,7 +77,8 @@ defvar RVA23U64Features = !listconcat(RVA22U64Features,
                                        FeatureStdExtSupm]);
 
 defvar RVA23S64BaseFeatures = !listconcat(RVA22S64BaseFeatures,
-                                          [FeatureStdExtSvnapot,
+                                          [FeatureStdExtH,
+                                           FeatureStdExtSvnapot,
                                            FeatureStdExtSstc,
                                            FeatureStdExtSscofpmf,
                                            FeatureStdExtSsnpm,

@topperc
Copy link
Collaborator

topperc commented Nov 9, 2024

Isn't H implied by FeatureStdExtSha?

@ppenzin
Copy link
Contributor Author

ppenzin commented Nov 9, 2024

Yep, it is, just realized.

@ppenzin ppenzin closed this Nov 9, 2024
@topperc
Copy link
Collaborator

topperc commented Nov 9, 2024

See also #113823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants