Skip to content

llvm/lib/CodeGen/RegAllocGreedy.h:428: Pointless copy of object ? #95033

Closed
@dcb314

Description

@dcb314

Static analyser cppcheck says:

llvm/lib/CodeGen/RegAllocGreedy.h:428:28: performance: Function parameter 'other' should be passed by const reference. [passedByValue]

Source code is

void add(RAGreedyStats other) {

Suggest new code

void add( const RAGreedyStats & other) {

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions