Skip to content

Conversation

@bnussman-akamai
Copy link
Member

Description 📝

Preview 📷

Screenshot 2025-02-20 at 1 27 01 PM
Screenshot 2025-02-20 at 1 26 58 PM

How to test 🧪

  • Verify all builds and checks succeed ✅
  • Verify local development works
  • Verify yarn why vite shows only v6.1.1 installed
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Feb 20, 2025
@bnussman-akamai bnussman-akamai self-assigned this Feb 20, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner February 20, 2025 18:30
@bnussman-akamai bnussman-akamai requested review from abailly-akamai and dwiley-akamai and removed request for a team February 20, 2025 18:30
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Approved pending test results, but the fact that Cloud builds + the tests are passing so far bodes pretty well I'd say

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending CI being happy - ty!

@github-actions
Copy link

Coverage Report:
Base Coverage: 79.98%
Current Coverage: 79.98%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 523 passing tests on test run #1 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing523 Passing3 Skipped107m 32s

@bnussman-akamai bnussman-akamai merged commit 9661e59 into linode:develop Feb 20, 2025
23 checks passed
@cypress
Copy link

cypress bot commented Feb 20, 2025

Cloud Manager E2E    Run #7260

Run Properties:  status check passed Passed #7260  •  git commit 9661e594ea: chore(deps): [M3-9356] - Update to Vite v6.1.1 (#11698)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7260
Run duration 30m 17s
Commit git commit 9661e594ea: chore(deps): [M3-9356] - Update to Vite v6.1.1 (#11698)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 523
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants