Skip to content

Conversation

@golovin12
Copy link
Contributor

  • disclaimer: The only thing I didn't add is support for additional targets in MissionEditorManager (I don't need this functionality - editing via file is sufficient, I don't want to figure out how everything works there)

Fixes:

  1. Dependency on maximum level was not used everywhere - fixed
  2. Fixed a bug where next_coin_distribution was not initialized
  3. Fixed the plugin enable message, now it's not read from config (not all consoles support colors, and then gibberish is displayed instead of a normal message)
  4. Removed unused arguments in method calls (to avoid confusion that these arguments might affect something)
  5. Fixed old progress cleanup (previously today's data was not deleted)
  6. Fixed a bug where trading tasks were counted even if the player had not exchanged anything.

Expanded Missions:

  1. Added an additional_targets field, now more general tasks can be created (my players constantly complained that mining a certain ore wasn't counted because it's not obvious that regular ore is not the same as deepslate ore.)
    Example:
  mine-iron:
    type: MINE_BLOCK
    target: IRON_ORE
    additional-targets:
      - DEEPSLATE_IRON_ORE
    display-name: "Mine <amount> Iron Ores"
    min-required: 20
    max-required: 60
    min-xp: 150
    max-xp: 250
    weight: 10
  1. Expanded the trading mission, now besides just trading you can specify specific professions to trade with:
    Example:
  trade-agriculture:
    type: TRADE_VILLAGER
    target: FARMER
    additional-targets:
      - FISHERMAN
      - SHEPHERD
      - BUTCHER
    display-name: "Trade with Agriculture Villagers <amount> Times"
    min-required: 5
    max-required: 20
    min-xp: 200
    max-xp: 400
    weight: 7
  1. Expanded the enchanting mission, now you can also specify specific items that need to be enchanted:
    Example:
  enchant-swords:
    type: ENCHANT_ITEM
    target: DIAMOND_SWORD
    additional-targets:
      - NETHERITE_SWORD
      - IRON_SWORD
      - GOLDEN_SWORD
      - STONE_SWORD
      - WOODEN_SWORD
    display-name: "Enchant <amount> swords"
    min-required: 3
    max-required: 10
    min-xp: 250
    max-xp: 500
    weight: 6
  1. Expanded damage dealing missions, now you can specify specific entities that need to be damaged:
    Example:
  damage-sea-creatures:
    type: DAMAGE_DEALT
    target: GUARDIAN
    additional-targets:
      - ELDER_GUARDIAN
      - SQUID
      - GLOW_SQUID
      - DOLPHIN
      - TURTLE
      - COD
      - SALMON
      - PUFFERFISH
      - TROPICAL_FISH
      - AXOLOTL
    display-name: "Deal <amount> Damage to sea creatures"
    min-required: 700
    max-required: 3500
    min-xp: 200
    max-xp: 400
    weight: 7
  1. Expanded damage taken missions, now you can specify the damage source:
    Example:
  take-damage-fall:
    type: DAMAGE_TAKEN
    target: FALL
    display-name: "Take <amount> Damage from fall"
    min-required: 25
    max-required: 75
    min-xp: 100
    max-xp: 200
    weight: 9
  1. Expanded distance travel missions, now you can create tasks for flying, running, sneaking, swimming:
    Example:
  swim-distance:
    type: WALK_DISTANCE
    target: SWIM
    display-name: "Swim <amount> Blocks"
    min-required: 1500
    max-required: 7500
    min-xp: 160
    max-xp: 320
    weight: 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant