Skip to content

Conversation

@sfleen
Copy link
Contributor

@sfleen sfleen commented Oct 20, 2025

The bulk of the changes here are removing all references to the linkerd-jaeger extension, while also updating the docs for how to use tracing through the control plane values.

@sfleen sfleen force-pushed the sfleen/tracing-overhaul branch from c6b3cce to 8d0dd52 Compare October 20, 2025 18:15
@sfleen sfleen force-pushed the sfleen/tracing-overhaul branch from 8d0dd52 to 9f64879 Compare October 20, 2025 18:17
@sfleen sfleen marked this pull request as ready for review October 20, 2025 21:53
@sfleen sfleen requested a review from travisbeckham October 21, 2025 13:52
Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structurally everything looks good (Hugo, Markdown).

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me very happy. 🙂 There are some small changes that I'd like to see, but it still makes me very happy. 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this is used, but it seems weird to me that we don't show anything about trace propagation? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used near the top of this doc, it would need some pretty big changes to show the trace propagation which might clutter it.

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sfleen! I found some other mostly-grammar things to pick on, but I promise I'll merge this after that. 😂 🤦‍♂️

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🙂

@kflynn kflynn merged commit ea5ae2f into main Oct 30, 2025
7 checks passed
@kflynn kflynn deleted the sfleen/tracing-overhaul branch October 30, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants