-
Notifications
You must be signed in to change notification settings - Fork 216
chore: Overhaul tracing documentation #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6b3cce to
8d0dd52
Compare
Signed-off-by: Scott Fleener <[email protected]>
8d0dd52 to
9f64879
Compare
travisbeckham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structurally everything looks good (Hugo, Markdown).
kflynn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me very happy. 🙂 There are some small changes that I'd like to see, but it still makes me very happy. 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where this is used, but it seems weird to me that we don't show anything about trace propagation? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used near the top of this doc, it would need some pretty big changes to show the trace propagation which might clutter it.
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
kflynn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sfleen! I found some other mostly-grammar things to pick on, but I promise I'll merge this after that. 😂 🤦♂️
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
kflynn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it! 🙂
The bulk of the changes here are removing all references to the linkerd-jaeger extension, while also updating the docs for how to use tracing through the control plane values.