-
Notifications
You must be signed in to change notification settings - Fork 216
circuit breaking reference documentation #1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c46155 to
5ad8c83
Compare
kflynn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions and minor nits, but this looks very helpful overall, thanks!!
| 503 Service Unavailable errors, or, if the load balancer is part of a route | ||
| distribution with multiple backends, the entire backend Service will be | ||
| considered unavailable and a different backend may be selected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I know what "part of a route distribution with multiple backends" means. 🙂 "One of multiple backendRefs in an HTTPRoute"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wanted to have this link to the HTTPRoute docs section but am waiting for #1590 to merge so that i can add the links. i think changing it to refer specifically to HTTPRoute/backendRef is a good call regardless!
| Linkerd proxy performs circuit breaking at the level of individual endpoints | ||
| in a load balancer (i.e., each Pod in a given Service), and failures are tracked | ||
| at the level of HTTP response status codes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think the people reading the docs know what we mean by "load balancer" here? Should we talk about how Services can aggregate endpoints, but since HTTPRoutes can aggregate Services, HTTPRoutes can aggregate endpoints too?
| will attempt to determine whether the endpoint is still in a failing state, and | ||
| transition it back to available if it has recovered. This process is called | ||
| _probation_. When an endpoint enters probatiion, it is available for a single | ||
| request, called a _probe request_. If this request succeeds, the endpoint is no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The probe request is an actual workload request, right? Linkerd doesn't do some special healthz probe or any such thing?
| those endpoints while they are in a failed state. When all endpoints in a load | ||
| balancer are unavailable, requests may be failed with [503 Service Unavailable] | ||
| errors, or, if the Service is one of multiple [`backendRef`s in an | ||
| HTTPRoute](../httproute/#httpbackendref), the entire backend Service will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link is going to be broken until #1590 merges, but i wanted to go ahead and add the link so i didn't forget to later.
kflynn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hit it! 🙂
No description provided.