Skip to content

Conversation

@hawkw
Copy link
Contributor

@hawkw hawkw commented Apr 7, 2023

No description provided.

@hawkw hawkw marked this pull request as ready for review April 7, 2023 22:26
@hawkw hawkw changed the title [WIP] circuit breaking reference documentation circuit breaking reference documentation Apr 7, 2023
@hawkw hawkw requested review from adleong, olix0r and risingspiral April 7, 2023 22:37
@hawkw hawkw force-pushed the eliza/breaker-reference branch from 5c46155 to 5ad8c83 Compare April 10, 2023 18:50
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions and minor nits, but this looks very helpful overall, thanks!!

Comment on lines 29 to 33
503 Service Unavailable errors, or, if the load balancer is part of a route
distribution with multiple backends, the entire backend Service will be
considered unavailable and a different backend may be selected.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I know what "part of a route distribution with multiple backends" means. 🙂 "One of multiple backendRefs in an HTTPRoute"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to have this link to the HTTPRoute docs section but am waiting for #1590 to merge so that i can add the links. i think changing it to refer specifically to HTTPRoute/backendRef is a good call regardless!

Comment on lines 19 to 21
Linkerd proxy performs circuit breaking at the level of individual endpoints
in a load balancer (i.e., each Pod in a given Service), and failures are tracked
at the level of HTTP response status codes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think the people reading the docs know what we mean by "load balancer" here? Should we talk about how Services can aggregate endpoints, but since HTTPRoutes can aggregate Services, HTTPRoutes can aggregate endpoints too?

will attempt to determine whether the endpoint is still in a failing state, and
transition it back to available if it has recovered. This process is called
_probation_. When an endpoint enters probatiion, it is available for a single
request, called a _probe request_. If this request succeeds, the endpoint is no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The probe request is an actual workload request, right? Linkerd doesn't do some special healthz probe or any such thing?

@hawkw hawkw requested a review from kflynn April 10, 2023 19:27
those endpoints while they are in a failed state. When all endpoints in a load
balancer are unavailable, requests may be failed with [503 Service Unavailable]
errors, or, if the Service is one of multiple [`backendRef`s in an
HTTPRoute](../httproute/#httpbackendref), the entire backend Service will be
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is going to be broken until #1590 merges, but i wanted to go ahead and add the link so i didn't forget to later.

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit it! 🙂

@hawkw hawkw merged commit 88b0146 into main Apr 10, 2023
@hawkw hawkw deleted the eliza/breaker-reference branch April 10, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants