Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export SUPPORTED_ARCHS=${SUPPORTED_ARCHS:-linux/amd64,linux/arm64}
# Splitting of DOCKER_IMAGES variable is desired.
# shellcheck disable=SC2206
export DOCKER_IMAGES=(${DOCKER_IMAGES:-
cli-bin
controller
metrics-api
debug
Expand Down
4 changes: 2 additions & 2 deletions bin/build-cli-bin
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

set -eu

# Builds CLI binary for current platform only and outside docker to speed up things. Suitable for local development.
# Builds CLI binary for current platform. Suitable for local development.
# Note: This script is used by Brew when running `brew install linkerd`:
# https://github.com/Homebrew/homebrew-core/pull/36957
# https://github.com/Homebrew/homebrew-core/blob/main/Formula/l/linkerd.rb

bindir=$( cd "${0%/*}" && pwd )
rootdir=$( cd "$bindir"/.. && pwd )
Expand Down
5 changes: 0 additions & 5 deletions bin/docker-build
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,5 @@ bindir=$( cd "${0%/*}" && pwd )
"$bindir"/docker-build-controller
"$bindir"/docker-build-web
"$bindir"/docker-build-debug
if [ -z "${LINKERD_LOCAL_BUILD_CLI:-}" ]; then
"$bindir"/docker-build-cli-bin
else
"$bindir"/build-cli-bin
fi
"$bindir"/docker-build-metrics-api
"$bindir"/docker-build-tap
7 changes: 7 additions & 0 deletions cli/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,10 @@ COPY --from=build-linux-arm64 /out/* /
COPY --from=build-darwin /out/* /
COPY --from=build-darwin-arm64 /out/* /
COPY --from=build-windows /out/* /

# NB: This image does not contain an `ENTRYPOINT` directive. The filesystem
# of this image is used as a layer in other images in CI, and the CLI is
# typically used by operators outside of a cluster.
#
# Running `docker build` for this image will likely fail with an error like:
# "Error response from daemon: No command specified."