fix(tracing): Resync informer cache in root owner retries #14690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Companion to #14682 The previous retry logic relied on direct metadata API calls in cases where the informer cache hadn't updated when injecting a pod. This updates the retry logic to force a refresh of the informer cache instead of going to the metadata API. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
sfleen/root-owner-retry-update
branch
from
a852055 to
7321226
Compare
adleong
requested changes
Nov 7, 2025
| // which leaves a small possibility that the informer cache hasn't | ||
| // picked up the new resource yet. If that is the case, we force an | ||
| // informer resync to pick up the new resource. | ||
| api.Sync(nil) |
Member
There was a problem hiding this comment.
This doesn't force an informer resync. This simply starts each informer (they are already started at this point) and waits for them to have their initial data. I believe that this is a no-op at this point and doesn't guarantee that the object we want will be in cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to #14682
The previous retry logic relied on direct metadata API calls in cases where the informer cache hadn't updated when injecting a pod.
This updates the retry logic to force a refresh of the informer cache instead of going to the metadata API.