Skip to content

fix(helm): Use parentesized guards for control plane tracing #14636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
+1 −1
Merged

fix(helm): Use parentesized guards for control plane tracing #14636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/partials/templates/_trace.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ define "partials.linkerd.trace" -}}
{{ if .Values.controller.tracing.enabled -}}
{{ if ((.Values.controller.tracing).enabled) -}}
{{- if empty .Values.controller.tracing.collector.endpoint }}
Copy link
Member

@olix0r olix0r Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need defaults if collector is missing?

Copy link
Member

@olix0r olix0r Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- if empty .Values.controller.tracing.collector.endpoint }}
{{- if empty (.Values.controller.tracing.collector).endpoint }}

{{- fail "controller.tracing.collector.endpoint must be set if control plane tracing is enabled" }}
{{- end }}
Expand Down