feat(destionation): add --stream-queue-capacity arg #14622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destination controller has a hardcoded stream queue capacity of 100. This commit introduces a new command-line argument `--stream-queue-capacity` that allows users to customize this value according to their needs. We believe that '1' is a better default value for most use cases, as it reduces memory consumption and latency. However, we want to be incremental about this change. Therefore, this configuration allows for us to test this new default value in a controlled manner.
adleong
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination controller has a hardcoded stream queue capacity of 100. This commit introduces a new command-line argument
--stream-queue-capacitythat allows users to customize this value according to their needs.We believe that '1' is a better default value for most use cases, as it more eagerly detects backpressure and liveness issues. However, we want to be incremental about this change. Therefore, this configuration allows for us to test this new default value in a controlled manner.