fix(spiffe-proto): generate proto bindings without embedding package definition #4324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our workload.proto package has a package definition in it. We rely on that package definition for naming our generated protobuf file. We however do not want the package details being part of the service/method names of the generated client code.
For that purpose we have used the
disable_package_emissionmethod successfully in the past in order to generate code that does not have the package details in the service/method names.When we moved to tonic_prost_build however in this PR, we have lost this functionality as the
emit_packagemethod does not seem to be honored.In order to fix that and revert back to generating code with the correct service definitions while still preserving the name of the generated rust file, this PR:
_.rsfile to what it is supposed to be