chore(tracing): Refactor trace label population #4235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
force-pushed
the
sfleen/trace-service-name
branch
from
d1636c5 to
cc8be0a
Compare
This also does some considerable refactoring to the trace label population, simplifying the flow and making it much clearer where values are set and overridden by other values. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
sfleen/trace-service-name
branch
from
cc8be0a to
9aab0e4
Compare
cratelyn
reviewed
Oct 8, 2025
Member
cratelyn
left a comment
cratelyn
left a comment
There was a problem hiding this comment.
✨ this is nice! i have some small comments about how these interfaces fit together. i'll couch these comments with a note that the environment code here is lengthy, but these propositions should help cut out some non-local reasoning and help simplify the call-site to create this label set.
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
🎉 wahoo!
olix0r
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also does some considerable refactoring to the trace label population, simplifying the flow and making it much clearer where values are set and overridden by other values.