feat(tracing): Set trace service name from workload name #4224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all proxies must share the same trace service name, which makes querying for proxy traces much less useful. This updates the trace service name to be set via pod annotations, populated by the downward API. If none of those annotations are available, we can fallback to the global trace name. This also does some considerable refactoring to the trace label population, simplifying the flow and making it much clearer where values are set and overridden by other values. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
sfleen/trace-service-name
branch
from
95d974b to
2d2f338
Compare
Collaborator
Author
|
Closing in favor of a control plane solution linkerd/linkerd2#14592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all proxies must share the same trace service name, which makes querying for proxy traces much less useful.
This updates the trace service name to be set via pod annotations, populated by the downward API. If none of those annotations are available, we can fallback to the global trace name.
This also does some considerable refactoring to the trace label population, simplifying the flow and making it much clearer where values are set and overridden by other values.