refactor(app/outbound): remove frivolous NewService<T> bounds
#4190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these bounds are extensive, but don't serve a mechanical purpose at the moment. we can simplify our route metrics layer in the outbound proxy by removing them. Signed-off-by: katelyn martin <[email protected]>
olix0r
reviewed
Sep 24, 2025
Member
olix0r
left a comment
olix0r
left a comment
There was a problem hiding this comment.
So, these aren't load-bearing, but they are a helpful assertion if changes are made that break the stack's compilation: these assertions will give a clearer indication of why the N type isn't used.
At a minimum, I'd suggest preserving the N: svc::NewService<T> assertion which is idiomatic and lightweight
> So, these aren't load-bearing, but they are a helpful assertion if > changes are made that break the stack's compilation: these assertions > will give a clearer indication of why the N type isn't used. > > At a minimum, I'd suggest preserving the `N: svc::NewService<T>` > assertion which is idiomatic and lightweight this commit restores the innermost bound that `N` is a `NewService<T>`. Signed-off-by: katelyn martin <[email protected]>
Member
Author
|
that's a fair point! i've pushed 0e166d3, which restores the innermost |
olix0r
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these bounds are extensive, but don't serve a mechanical purpose at the
moment.
we can simplify our route metrics layer in the outbound proxy by
removing them.
Signed-off-by: katelyn martin [email protected]