refactor(app/inbound): type aliases specify extractors #4189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Sep 24, 2025
cratelyn
force-pushed
the
kate/app-inbound.prepare-metric-imports
branch
2 times, most recently
from
f5f14f1 to
0444b1d
Compare
cratelyn
force-pushed
the
kate/app-inbound.metrics-layer-aliases
branch
from
06a29fe to
81d037b
Compare
Base automatically changed from
kate/app-inbound.prepare-metric-imports
to
main
September 24, 2025 20:14
our metrics layer is generic across an `N`-typed service factory. this commit introduces types aliases that apply `X`-typed extractor parameters to the `linkerd-http-prom` middleware, which are unaware of a concrete metrics extractor. we use this to reduce the complexity of the `layer()` function's type signature. see #4180. NB: based upon #4188, and #4186. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/app-inbound.metrics-layer-aliases
branch
from
81d037b to
9cf2df9
Compare
cratelyn
added a commit
that referenced
this pull request
Sep 26, 2025
this commit introduces an additional layer of telemetry to the inbound proxy's http router. either http and grpc metrics are used, depending upon the policy that authorized a given request. this is based upon #4174, which refactored the request body telemetry middleware to be metrics agnostic. see: * #4189 * #4188 * #4187 * #4186 * #4174 * #4165 * #4166 * #4127 Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our metrics layer is generic across an
N-typed service factory.this commit introduces types aliases that apply
X-typed extractorparameters to the
linkerd-http-prommiddleware, which are unaware ofa concrete metrics extractor.
we use this to reduce the complexity of the
layer()function'stype signature.
see #4180.
NB: based upon #4188, and
#4186.
Signed-off-by: katelyn martin [email protected]