piet-web improvements
#499
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avitex
force-pushed
the
piet-web-work
branch
2 times, most recently
from
a145dd6 to
924aad6
Compare
It looks like this was never updated for a change in what is considered an anchor point from the baseline to the top of the layout box. This change checks that the hit point Y is past the new anchor point. See: linebender#311 (comment)
avitex
force-pushed
the
piet-web-work
branch
from
924aad6 to
ede7a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this up as a draft for some general fixes and improvements related to
piet-web.Looks like some stuff needs to be updated to reflect some changes elsewhere, specifically in regard to text anchor points.
piet-web