Define keywords for flex components #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokuzon
approved these changes
Dec 27, 2023
Contributor
Author
|
Thank you for review! |
Yang-33
added a commit
to line/line-bot-sdk-java
that referenced
this pull request
Jan 31, 2024
line/line-openapi#46 defines keywords for flex messages and template messages. In addition to keywords, template messages and flex messages can specify values in percentages or pixels. (e.g. image size in flex message: https://developers.line.biz/en/docs/messaging-api/flex-message-layout/#image-size) This just supports converting enum to string value for bot sdk users, and users can select one of raw value or enum.toValue(). Resolve #1155
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request defines the keywords that can be specified for template messages and flex messages as enums. In addition to keywords, template messages and flex messages can specify values in percentages or pixels.
(e.g. image size in flex message: https://developers.line.biz/en/docs/messaging-api/flex-message-layout/#image-size)
Therefore, we will not define the new enum as a value that can be specified for template messages and flex messages.
The main purpose of this change is to provide support for users who use the bot SDK to have the option to use enums.
Resolve #42