Skip to content

Conversation

@unnoy
Copy link
Contributor

@unnoy unnoy commented Sep 28, 2023

According to the doc below, the endpoint accepts limit query parameter to limit the number of IDs to fetch per one request.
https://developers.line.biz/en/reference/messaging-api/#get-follower-ids

i think it is effective when fetching results by specific chunk size. besides, it can reduce the query cost when it fetches lesser size from the default value.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d7e9f95) 78.93% compared to head (ee3f3f0) 78.90%.

❗ Current head ee3f3f0 differs from pull request most recent head c512e5e. Consider uploading reports for the commit c512e5e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   78.93%   78.90%   -0.03%     
==========================================
  Files          40       40              
  Lines        3712     3726      +14     
==========================================
+ Hits         2930     2940      +10     
- Misses        590      592       +2     
- Partials      192      194       +2     
Files Coverage Δ
linebot/get_follower_ids.go 75.00% <76.47%> (-0.81%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @unnoy
Thank you for your PR, would you please help to check the comment?

@unnoy unnoy requested a review from kkdai September 28, 2023 07:56
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit 424732d into line:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants