Skip to content

Conversation

@s-aska
Copy link
Contributor

@s-aska s-aska commented Sep 21, 2023

It seems that the InoutOption of PostbackAction is missing from RichMenuAction.

official doc: https://developers.line.biz/ja/reference/messaging-api/#postback-action
ref: https://github.com/line/line-bot-sdk-go/blob/master/linebot/actions.go#L113

I'm not very experienced, so please let me know if there's anything amiss or if I've overlooked something.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (df06aa0) 78.93% compared to head (0d8de23) 78.93%.
Report is 1 commits behind head on master.

❗ Current head 0d8de23 differs from pull request most recent head aadd908. Consider uploading reports for the commit aadd908 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files          40       40           
  Lines        3712     3712           
=======================================
  Hits         2930     2930           
  Misses        590      590           
  Partials      192      192           
Files Changed Coverage Δ
linebot/richmenu.go 62.60% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yang-33 Yang-33 merged commit 54ac9ca into line:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants