Skip to content

Conversation

@kkdai
Copy link
Member

@kkdai kkdai commented Jul 31, 2023

golang 1.18 was already EOL. time to go to the 1.19!
https://endoflife.date/go

@John-Lin
Copy link
Member

LGTM

Copy link
Contributor

@tokuhirom tokuhirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But we may need to use the golint alternative to keep code quality after merge this PR.

@kkdai
Copy link
Member Author

kkdai commented Jul 31, 2023

ok, file another issue #352 to follow-up.

@kkdai kkdai merged commit f684564 into line:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants