Skip to content

Conversation

@testwill
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023

CLA assistant check
All committers have signed the CLA.

@kkdai kkdai self-requested a review July 31, 2023 02:14
@kkdai
Copy link
Member

kkdai commented Jul 31, 2023

Checking the PR.

Add reason:
io/ioutil is deprecated since go 1.16, refer to https://pkg.go.dev/io/ioutil

@kkdai
Copy link
Member

kkdai commented Jul 31, 2023

Hi @testwill
Would you please help to sigh the CLA?

@kkdai
Copy link
Member

kkdai commented Jul 31, 2023

Since this change (#321), we should move forward our package to 1.19.
Let me check with other reviewers

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit 527ce48 into line:master Jul 31, 2023
@testwill testwill deleted the ioutil branch July 31, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants