Skip to content

Conversation

@blackhun11
Copy link
Contributor

adding new method based on issue here #337. please help to review @kkdai

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2023

CLA assistant check
All committers have signed the CLA.

@blackhun11
Copy link
Contributor Author

cc @kkdai

@kkdai kkdai self-requested a review February 2, 2023 04:48
@codecov-commenter
Copy link

Codecov Report

Base: 78.80% // Head: 78.77% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0b0a819) compared to base (e049ef8).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   78.80%   78.77%   -0.03%     
==========================================
  Files          39       39              
  Lines        3576     3600      +24     
==========================================
+ Hits         2818     2836      +18     
- Misses        578      581       +3     
- Partials      180      183       +3     
Impacted Files Coverage Δ
linebot/client.go 69.46% <ø> (ø)
linebot/response.go 68.50% <50.00%> (-0.47%) ⬇️
linebot/oauth.go 88.23% <87.50%> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blackhun11
Copy link
Contributor Author

hi @kkdai , just in case you forget this. is it good to go?

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you.

@kkdai kkdai merged commit 512ce70 into line:master Feb 3, 2023
@kkdai kkdai linked an issue Feb 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify channel access token method

4 participants