Skip to content

Support VideoComponent in Flex message #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kkdai merged 1 commit into from
Mar 17, 2022
Merged

Support VideoComponent in Flex message #306

kkdai merged 1 commit into from
Mar 17, 2022

Conversation

@david7482
Copy link
Contributor

@david7482 david7482 commented Mar 16, 2022

#305

  • Add FlexVideoAspectRatioType for some common video aspect ratios (and the inverse ones)
  • Add VideoComponent which is also a FlexComponent

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kkdai kkdai self-requested a review March 17, 2022 03:04
kkdai
kkdai approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@kkdai kkdai merged commit 8c53242 into line:master Mar 17, 2022
@kkdai kkdai mentioned this pull request Mar 17, 2022
Closed
@kkdai kkdai linked an issue Mar 17, 2022 that may be closed by this pull request
Flex Message Update 3 released #305
Closed
@david7482 david7482 deleted the david7482/flex-video branch March 17, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkdai kkdai kkdai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flex Message Update 3 released

3 participants

@david7482 @CLAassistant @kkdai