-
Notifications
You must be signed in to change notification settings - Fork 244
add managing audience api #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 78.53% 79.29% +0.76%
==========================================
Files 37 38 +1
Lines 2874 3366 +492
==========================================
+ Hits 2257 2669 +412
- Misses 486 530 +44
- Partials 131 167 +36
Continue to review full report at Codecov.
|
|
Hi @justdomepaul |
|
@kkdai all right. Maybe wait me 3~5 days to add some test to coverage audience.go |
|
@kkdai I finish audience.go test case. Can you spend some time to review it? |
kkdai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM
add managing audience api to SDK.
Unit test is not finished.
Ref issue: Support Audience apis