Skip to content

Conversation

@justdomepaul
Copy link
Contributor

add managing audience api to SDK.

Unit test is not finished.

Ref issue: Support Audience apis

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #302 (7b873f2) into master (c7bd560) will increase coverage by 0.76%.
The diff coverage is 82.92%.

❗ Current head 7b873f2 differs from pull request most recent head fbab5a7. Consider uploading reports for the commit fbab5a7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   78.53%   79.29%   +0.76%     
==========================================
  Files          37       38       +1     
  Lines        2874     3366     +492     
==========================================
+ Hits         2257     2669     +412     
- Misses        486      530      +44     
- Partials      131      167      +36     
Impacted Files Coverage Δ
linebot/client.go 69.46% <60.97%> (-3.87%) ⬇️
linebot/response.go 68.96% <66.66%> (-0.68%) ⬇️
linebot/audience.go 88.39% <88.39%> (ø)
linebot/error.go 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bd560...fbab5a7. Read the comment docs.

@kkdai kkdai self-requested a review February 22, 2022 10:13
@kkdai
Copy link
Member

kkdai commented Feb 22, 2022

Hi @justdomepaul
Would you please help to add some testing cases for audience.go ?

@justdomepaul
Copy link
Contributor Author

justdomepaul commented Feb 22, 2022

@kkdai all right. Maybe wait me 3~5 days to add some test to coverage audience.go

@kkdai kkdai linked an issue Feb 23, 2022 that may be closed by this pull request
5 tasks
@justdomepaul
Copy link
Contributor Author

@kkdai I finish audience.go test case. Can you spend some time to review it?

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@kkdai kkdai merged commit 4806c73 into line:master Feb 24, 2022
@kkdai kkdai linked an issue Feb 24, 2022 that may be closed by this pull request
9 tasks
@kkdai kkdai mentioned this pull request Feb 24, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Messaging API - August 2020 update Support Audience apis

3 participants