Skip to content

Conversation

@wingyplus
Copy link

No description provided.

Comment on lines +16 to +22
- 1.11
- 1.12
- 1.13
- 1.14
- 1.15
- 1.16
- 1.17
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If running on every version is a bit too much. Maybe we can just support only the last 3 (or 4) versions. ^^

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #297 (214ab32) into master (5ace314) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   78.50%   78.50%           
=======================================
  Files          37       37           
  Lines        2870     2870           
=======================================
  Hits         2253     2253           
  Misses        486      486           
  Partials      131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ace314...214ab32. Read the comment docs.

@kkdai
Copy link
Member

kkdai commented Dec 28, 2021

@wingyplus Thank you for your PR, how about we just remain following versions? :

  • 1.11 (gomodule enable)
  • 1.13 (default vendor on)
  • 1.16 (ARM support)
  • 1.17 (latest version)

What do you think?

@wingyplus
Copy link
Author

wingyplus commented Dec 29, 2021

@wingyplus Thank you for your PR, how about we just remain following versions? :

* 1.11 (gomodule enable)

* 1.13 (default vendor on)

* 1.16 (ARM support)

* 1.17 (latest version)

What do you think?

@kkdai I think the 2 last versions would be enough, In this case, 1.16 and 1.17. We may add a beta version (such as 1.18-beta.1) to make it doesn't have bugs for future releases.

@kkdai
Copy link
Member

kkdai commented Dec 29, 2021

image

image

We could stay original modification since it only impact 8s (original 60s ---> 68s)

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit a1681df into line:master Dec 29, 2021
@wingyplus wingyplus deleted the ci branch December 29, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants