Skip to content

Conversation

@gotokatsuya
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2021

CLA assistant check
All committers have signed the CLA.

@kkdai
Copy link
Member

kkdai commented Jul 15, 2021

@clsung Would you help to check this one?

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #286 (5b3a012) into master (81a4a47) will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   76.82%   77.94%   +1.11%     
==========================================
  Files          36       36              
  Lines        2447     2847     +400     
==========================================
+ Hits         1880     2219     +339     
- Misses        436      497      +61     
  Partials      131      131              
Impacted Files Coverage Δ
linebot/event.go 88.82% <ø> (+0.25%) ⬆️
linebot/richmenu.go 61.24% <ø> (+0.37%) ⬆️
linebot/message.go 78.52% <0.00%> (-3.84%) ⬇️
linebot/delivery.go 69.69% <0.00%> (-0.68%) ⬇️
linebot/emoji.go 100.00% <0.00%> (ø)
linebot/error.go 0.00% <0.00%> (ø)
linebot/leave.go 100.00% <0.00%> (ø)
linebot/sender.go 100.00% <0.00%> (ø)
linebot/insight.go 100.00% <0.00%> (ø)
linebot/progress.go 100.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a4a47...5b3a012. Read the comment docs.

@clsung
Copy link
Contributor

clsung commented Jul 15, 2021

Can you add some unit tests?

@gotokatsuya
Copy link
Contributor Author

OK

@gotokatsuya
Copy link
Contributor Author

@clsung I just add webhook test. Could you check it? Let me know if you have better test.

Copy link
Contributor

@clsung clsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit 369271e into line:master Jul 17, 2021
@gotokatsuya gotokatsuya deleted the patch/richmenuaction branch July 19, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants