-
Notifications
You must be signed in to change notification settings - Fork 244
Fix #285 Support rich menu switch action #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@clsung Would you help to check this one? |
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 76.82% 77.94% +1.11%
==========================================
Files 36 36
Lines 2447 2847 +400
==========================================
+ Hits 1880 2219 +339
- Misses 436 497 +61
Partials 131 131
Continue to review full report at Codecov.
|
|
Can you add some unit tests? |
|
OK |
|
@clsung I just add webhook test. Could you check it? Let me know if you have better test. |
clsung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kkdai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#285