Skip to content

Conversation

@54m
Copy link
Contributor

@54m 54m commented Apr 18, 2021

Overview

See commit.

  1. 58ea1fe Fix the wrong constant type ⚠️
  2. 4e4cc43 Typo correction
  3. b89478c Cleanup code
  4. 53161b7 Consider nil ⚠️
  5. f670bb4 Fixed to the correct tag name(omitemtpy -> omitempty) ⚠️

Other

Typo errors in public names have not been corrected.
I'd like to fix the public name as well ... :(

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@9047ed5). Click here to learn what that means.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #278   +/-   ##
=========================================
  Coverage          ?   77.57%           
=========================================
  Files             ?       36           
  Lines             ?     2288           
  Branches          ?        0           
=========================================
  Hits              ?     1775           
  Misses            ?      393           
  Partials          ?      120           
Impacted Files Coverage Δ
linebot/client.go 68.00% <ø> (ø)
linebot/get_bot_info.go 100.00% <ø> (ø)
linebot/response.go 66.66% <ø> (ø)
linebot/richmenu.go 58.41% <ø> (ø)
linebot/message.go 81.73% <55.55%> (ø)
linebot/event.go 88.57% <100.00%> (ø)
linebot/oauth.go 86.20% <100.00%> (ø)
linebot/oauth2.go 86.66% <100.00%> (ø)
linebot/webhook.go 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9047ed5...f670bb4. Read the comment docs.

@kkdai kkdai self-requested a review April 18, 2021 15:43
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit f7781c7 into line:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants