Skip to content

Conversation

@wys1203
Copy link
Contributor

@wys1203 wys1203 commented Apr 8, 2021

Since PR #264 enabled the go module, it‘s better to follow the specification of the go module to upgrade the major version.

Currently, The latest version of package still stuck at v1.3.0 pkg.go.dev This change will help the version control back to the major line

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Apr 8, 2021

Codecov Report

Merging #273 (d9de242) into master (22cd2d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   77.66%   77.66%           
=======================================
  Files          36       36           
  Lines        2288     2288           
=======================================
  Hits         1777     1777           
  Misses        392      392           
  Partials      119      119           
Impacted Files Coverage Δ
linebot/httphandler/httphandler.go 71.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cd2d5...d9de242. Read the comment docs.

@kkdai kkdai self-requested a review April 8, 2021 06:33
@kkdai
Copy link
Member

kkdai commented Apr 8, 2021

Is this related to issue #274 ?

@wys1203
Copy link
Contributor Author

wys1203 commented Apr 8, 2021

Is this related to issue #274 ?

Yes, exactly. However, After we enabled the go module at the tag v7.9.0, We can’t go get github.com/line/line-bot-sdk-go v7.9.0+incompatible like we used to.

The expected behavior would be go get: github.com/line/[email protected]: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v7.

This PR will fix the issue by following the module specification.

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit 33b4804 into line:master Apr 8, 2021
@kkdai
Copy link
Member

kkdai commented Apr 8, 2021

Thank you @wys1203. I am going to release new version to fixed #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report - Could not update to latest version v7.9.0

4 participants