Skip to content

Add API for set webhook endpointURL #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kkdai merged 2 commits into from
Oct 29, 2020
Merged

Add API for set webhook endpointURL #241

kkdai merged 2 commits into from
Oct 29, 2020

Conversation

@hinoguma
Copy link
Contributor

@hinoguma hinoguma commented Oct 24, 2020 •
edited
Loading

@kkdai kkdai linked an issue Oct 25, 2020 that may be closed by this pull request
Messaging API - October 2020 update #233
Closed
4 tasks
@kkdai kkdai self-requested a review October 25, 2020 02:30
@kkdai
Copy link
Member

kkdai commented Oct 25, 2020

@hinoguma Would you please help to merge the conflict?

@hinoguma
Merge branch 'master' into feature/api-for-set-webhook-endpoint
61b9b66 
# Conflicts:
#	linebot/client.go
#	linebot/webhook.go
#	linebot/webhook_test.go
@hinoguma
Copy link
Contributor Author

hinoguma commented Oct 25, 2020

@kkdai
I merged and changed arrangement of BenchmarkParseRequest func in webhook_test.go.
Before merge, BenchmarkParseRequest is after TestGetWebhookInfoWithContext.
BenchmarkParseRequest should be after TestEventMarshaling becuase BenchmarkParseRequest is a test code for receiving webhook.

kkdai
kkdai approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit b4c3a9c into line:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkdai kkdai kkdai approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Messaging API - October 2020 update

2 participants

@hinoguma @kkdai