Skip to content

Conversation

@hinoguma
Copy link
Contributor

@hinoguma hinoguma commented Oct 11, 2020

Update Messaging API October 2020
https://developers.line.biz/en/news/2020/10/06/messaging-api-update-october-2020/

  • Get bot info
  • Get webhook endpoint information
  • Set webhook endpoint URL
  • Test webhook endpoint

@hinoguma hinoguma changed the title Add api for get-bot-info Add API for get-bot-info Oct 11, 2020
@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #232 into master will decrease coverage by 0.89%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   77.59%   76.70%   -0.90%     
==========================================
  Files          33       34       +1     
  Lines        2415     2086     -329     
==========================================
- Hits         1874     1600     -274     
+ Misses        436      380      -56     
- Partials      105      106       +1     
Impacted Files Coverage Δ
linebot/client.go 68.00% <ø> (-5.34%) ⬇️
linebot/response.go 66.11% <71.42%> (-3.94%) ⬇️
linebot/get_bot_info.go 100.00% <100.00%> (ø)
linebot/httphandler/httphandler.go 71.42% <0.00%> (-5.50%) ⬇️
linebot/webhook.go 71.42% <0.00%> (-3.58%) ⬇️
linebot/get_ids.go 78.31% <0.00%> (-2.94%) ⬇️
linebot/demographic_filter.go 85.00% <0.00%> (-2.76%) ⬇️
linebot/flex_unmarshal.go 66.37% <0.00%> (-2.49%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e385a...060169f. Read the comment docs.

@kkdai kkdai self-requested a review October 14, 2020 09:05
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, I have reviewed your PR.
Could you help to check for "displayName"

@hinoguma
Copy link
Contributor Author

Thank you for review.

Thank you for your PR, I have reviewed your PR.
Could you help to check for "displayName"

I fixed missing displayName.
Could you please review again ?

@hinoguma hinoguma requested a review from kkdai October 14, 2020 13:18
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, you almost finish with this PR.
Please help to fix the final part.

@hinoguma
Copy link
Contributor Author

Oh, sorry... I fixed and please check it.

@hinoguma hinoguma requested a review from kkdai October 14, 2020 17:00
@kkdai
Copy link
Member

kkdai commented Oct 14, 2020

Thank you for your hard work, it looks good to me.
Looking forward to seeing you for the rest of the API.

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit b644166 into line:master Oct 14, 2020
@kkdai kkdai mentioned this pull request Oct 14, 2020
4 tasks
@kkdai kkdai linked an issue Oct 14, 2020 that may be closed by this pull request
4 tasks
@kkdai kkdai removed a link to an issue Oct 25, 2020
4 tasks
@kkdai kkdai linked an issue Oct 25, 2020 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Messaging API - October 2020 update

3 participants